Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to not use the helper batch script #6

Merged
merged 1 commit into from
May 9, 2020

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented May 3, 2020

Choose vcvarsall.bat within JS code, call CMD directly with a command instead of writing a temporary file.

Choose vcvarsall.bat within JS code, call CMD directly with a command instead of writing a temporary file.
@oprypin oprypin changed the title Refactor to not use the helper script Refactor to not use the helper batch script May 3, 2020
@ilammy
Copy link
Owner

ilammy commented May 9, 2020

Oh... Right, that will be much more straightforward way to do this. Thank you! ❤️

I’m terribly sorry for the delayed response.

@ilammy ilammy merged commit 5a6b51d into ilammy:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants